-
Notifications
You must be signed in to change notification settings - Fork 12
feat: react router agent #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
daniloc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks right to me, can't wait to get it into testing. Couple things we can clean up for future integrations if you're up for it.
how was the DX of getting all this slotted in?
|
Gonna patch this up and get it in on Monday. What % should we roll out to on the feature flag? |
|
Let's say 50% and see if anyone's mad about it, now that we can trust the underlying mechanisms of the wizard itself |
|
Scary but down for it. |
Adds react router. Uses code in this examples PR and docs from this PR